#306: Add support for newer jakarta.servlet.http API into JsonRpcServer #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ip encoding parts Signed-off-by: cyb3r4nt <[email protected]>
…inside JsonRpcServer Common logic may be used to handle the HTTP requests. This is a preparation for using jakarta.servlet.http namespace objects. There are no much requirements for those interfaces, only some common methods, which are present in most Portlet API requests were not changed, because there is a comment, which assumes that HTTP status code is assigned outside. Added a TODO comment there with possible solution proposal. Signed-off-by: cyb3r4nt <[email protected]>
…into JsonRpcServer Both javax and jakarta objects/APIs have similar method signatures and differ only with types. Two new classes were added to adapt to the common interface. Not very last version of jakarta.servlet-api v5.0.0 was added, because project JDK target is Java 8. jakarta.servlet-api v5.0.0 comes from the Jakarta EE 9, which is still compatible with JDK 8. Signed-off-by: cyb3r4nt <[email protected]>
…onRpcServer Removed @SuppressWarnings from top-level place on top of the class. Currently only two handle() methods are shown as unused, but these are public API methods, which meant to be called by the clients. Signed-off-by: cyb3r4nt <[email protected]>
|
@briandilley do you have any concerns on this PR? Otherwise could I help @cyb3r4nt to improve the PR in order to push it to release? |
|
WEB_PARAM_ANNOTATION_CLASS_LOADER is hard coded to use javax. |
|
Any info about this? wanna try it with spring 6 |
|
Yeah, newer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#306: Add support for newer
jakarta.servlet.httpAPI intoJsonRpcServerAdded an additional method, which accepts
jakarta.servlet.http.HttpServletRequestandjakarta.servlet.http.HttpServletResponseas parameters.Extracted common interfaces for
javaxandjakartavariants.Now this can be used in the newer servlet containers and can also work with Spring Framework 6.
The drawback is that all users need to include
jakarta.servlet:jakarta.servlet-apiinto their classpath.